Fixed automated code review warnings

src/endpoints/auth.ts

@@ -14,7 +14,7 @@ async function login(request: UnwrappedRequest): Promise<Response> {
             refreshCount: string;
         } | null = await orm.users.verifyCredentials(requestBody.username, requestBody.password);
         if (!verify) {
-            throw new UnauthorizedError('Invalid credentials');
+            return new UnauthorizedResponse('Invalid credentials');
         }
 
         // Build refresh token that expires in 30 days, return as secure HTTP only cookie.
@@ -46,7 +46,7 @@ async function token(request: UnwrappedRequest): Promise<Response> {
         const cookies = request.request.cookies;
         const refreshCookie = cookies.get('refresh');
         if (!refreshCookie) {
-            throw new UnauthorizedError('No refresh token found');
+            return new UnauthorizedResponse('No refresh token found');
         }
 
         const refreshToken: {
@@ -69,7 +69,7 @@ async function token(request: UnwrappedRequest): Promise<Response> {
     }
 }
 
-async function logout(request: UnwrappedRequest): Promise<Response> {
+async function logout(): Promise<Response> {
     try {
         const response = new OkResponse();
         response.headers.set('Clear-Site-Data', '"cookies","cache","storage","executionContexts"');
@@ -79,14 +79,13 @@ async function logout(request: UnwrappedRequest): Promise<Response> {
     }
 }
 
-async function changePassword(request: UnwrappedRequest): Promise<Response> {
+async function changePassword(request: UnwrappedRequest<ChangePasswordRequest>): Promise<Response> {
     try {
-        const requestBody = request.body as ChangePasswordRequest;
         return new OkResponse(
             await orm.users.changePassword(
                 SecureId.fromHash(request.params.id),
-                requestBody.oldPassword,
+                request.body.oldPassword,
-                requestBody.newPassword,
+                request.body.newPassword,
                 request.claims,
             ),
         );

src/index.ts

@@ -11,7 +11,7 @@ const server = Bun.serve({
         ...player,
         ...game,
         '/test': {
-            GET: (request) => {
+            GET: () => {
                 return new OkResponse();
             },
         },

src/orm/games.ts

@@ -1,6 +1,6 @@
 import { Claims } from './claims';
 import { sql } from 'bun';
-import { first, memoize } from 'lodash';
+import { first } from 'lodash';
 import { NotFoundError, UnauthorizedError } from '../utilities/errors';
 import { CreateGameRequest, SecureId, UpdateGameRequest } from '../utilities/requestModels';
 import { memo } from '../utilities/helpers';

src/orm/players.ts

@@ -1,7 +1,7 @@
 import { Claims } from './claims';
 import { sql } from 'bun';
 import { first } from 'lodash';
-import { BadRequestError, NotFoundError, UnauthorizedError } from '../utilities/errors';
+import { NotFoundError, UnauthorizedError } from '../utilities/errors';
 import { orm } from './orm';
 import { SecureId, UpdatePlayerRequest } from '../utilities/requestModels';
 
@@ -28,7 +28,7 @@ export class Player {
 }
 
 export class PlayersOrm {
-    async create(model: {name: string}, claims?: Claims): Promise<Player | null> {
+    async create(model: { name: string }, claims?: Claims): Promise<Player | null> {
         await sql`INSERT INTO players (name)
                          VALUES (${model.name})`;
         const newPlayerId: string = (first(await sql`SELECT lastval();`) as any)?.lastval as string;
@@ -74,11 +74,7 @@ export class PlayersOrm {
 
     async update(
         id: SecureId,
-        patch: {
+        patch: UpdatePlayerRequest,
-            name?: string;
-            isRatingLocked?: boolean;
-            canBeMultiple?: boolean;
-        },
         claims?: Claims,
     ): Promise<Player | null> {
         if (!(Claims.test(Claims.ADMIN, claims) || Claims.test(Claims.PLAYERS.OTHER.UPDATE, claims))) {

src/orm/user.ts

@@ -92,7 +92,7 @@ export class UsersOrm {
 
     async update(
         id: SecureId,
-        patch: { isActive?: boolean; isAdmin?: boolean },
+        patch: UpdateUserRequest,
         claims?: Claims,
     ): Promise<User | null> {
         if (

src/utilities/guard.ts

@@ -29,7 +29,7 @@ export function guard(
         try {
             const userClaims: Claims = jwt.verify(authHeader as string, process.env.JWT_SECRET_KEY as string) as Claims;
             if (!userClaims.claims.some((x: string): boolean => guardedClaims.includes(x))) {
-                throw new UnauthorizedError('Unauthorized');
+                return new UnauthorizedResponse('Unauthorized');
             }
             return method(await unwrap(request, userClaims));
         } catch (error: any) {

src/utilities/responseHelper.ts

@@ -1,5 +1,4 @@
 import { BadRequestError, NotFoundError, UnauthorizedError } from './errors';
-import { hashIds } from './guard';
 
 export class ErrorResponse extends Response {
     //@ts-ignore